-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] update recommended template priority for override to 500 #119450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
leemthompo
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added backports so this will be added to supported 8.x documentation.
@leemthompo thank you! |
This was referenced Jan 3, 2025
endorama
added a commit
to endorama/elasticsearch
that referenced
this pull request
Jan 3, 2025
endorama
added a commit
to endorama/elasticsearch
that referenced
this pull request
Jan 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2025
sarog
pushed a commit
to portsbuild/elasticsearch
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #69006 recommendations for index template priorities where updated from
200
to500
.After the recent introduction of the APM Data plugin we noticed that the current recommendation has a possible conflict with the templates shipped with it (we were forced to use a priority of
210
to override Fleet templates which uses up to200
).See #115196
Overall #69006 updated all occurrences of priorities in the documentation to
500
, but we found a single sentence that could be misleading:To avoid confusion and prevent unwanted conflicts, this PR updates this sentence, in line with examples on the page, to suggest a priority of
500
instead of200
.Closes #115196
Note: we would like to include this change in
8.x
branch too, but I'm not sure how backport works for documentation so guidance would be appreciated.